[CRIU] Re: [PATCH] dump: Don't dump file params with on-stack values

Pavel Emelyanov xemul at parallels.com
Wed May 30 04:36:25 EDT 2012


On 05/28/2012 03:56 PM, Cyrill Gorcunov wrote:
> Otherwise I see output like
> 
>  | Dumping path for 1536412160 fd via self 27 [/usr/bin/screen]
> 
> where fd is taken from stack and what is worse -- we work
> with root privilegues, thus dumping _anything_ from stack
> is very bad idea.
> 
> With explicitly cleared stack data and FD_DESC_INVALID the
> log file will have an entry like
> 
>  | Dumping path for -3 fd via self 27 [/usr/bin/screen]
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>

Applied


More information about the CRIU mailing list