[CRIU] Re: [PATCH 1/3] make: remove OBJ on BLOBS dependence

Cyrill Gorcunov gorcunov at openvz.org
Mon May 28 07:31:34 EDT 2012


On Mon, May 28, 2012 at 03:24:13PM +0400, Kinsbursky Stanislav wrote:
> This dependence is redundant, because Makefile itself depends on DEPS, which
> it turn depends on BLOBS.
> 
> Signed-off-by: Stanislav Kinsbursky <skinsbursky at openvz.org>
> ---

NAK. This is wrong approach. The idea of deps as self -- is that
they're used to figure out which files were updated before continue
building the main target. Thus if some object (!) files or main
executable fail depends on another object files (in our case
on sys-objs and pie-generated files) we should mention it
explicitly and never _hide_ under DEPS target.

Sure, what you propose will work, but from my POV it's wrong
by design.

The rest of the series looks good to me.

	Cyrill


More information about the CRIU mailing list