[CRIU] Re: [PATCH 3/7] sockets, unix: Use general machnism for checkpoint/restore

[Cyrill Gorcunov]

On Wed, May 16, 2012 at 12:50:42AM +0400, Pavel Emelyanov wrote:
> > +
> > +	return NULL;
> > +}
> > +
> 
> Don't obfuscate fdinfo_desc hash please. Use separate list/hash of unix sockets
> if required.
> 

OK.

> >  int sk_collect_one(int ino, int family, struct socket_desc *d)
> >  {
> >  	struct socket_desc **chain;
> > @@ -125,16 +135,13 @@ int dump_socket_opts(int sk, struct sk_opts_entry *soe)
> >  int dump_socket(struct fd_parms *p, int lfd, const struct cr_fdset *cr_fdset)
> >  {
> >  	struct socket_desc *sk;
> > -
> >  	sk = lookup_socket(p->stat.st_ino);
> > -	if (!sk) {
> > -		pr_err("Uncollected socket 0x%8x\n", (int)p->stat.st_ino);
> > +	if (!sk)
> >  		return -1;
> > -	}
> 
> I don't understand this "tossing bits around" change set.

Crap, I think I  did it automatically, sorry.

	Cyrill