[CRIU] Re: [RFC] inet unbound sockets restore

Cyrill Gorcunov gorcunov at openvz.org
Sat May 12 10:43:46 EDT 2012


On Sat, May 12, 2012 at 06:40:39PM +0400, Pavel Emelyanov wrote:
> >>>  
> >>> -	if (inet_bind(sk, ii))
> >>> +	if (ii->ie.state != TCP_CLOSE && inet_bind(sk, ii))
> >>>  		goto err;
> >>>  
> >>>  	if (ii->ie.state == TCP_LISTEN) {
> >>
> >> O_o
> > 
> > Not really sure I follow, what do yo don't like here?
> 
> What is this check here for? I mean -- e.g. unbound UDP socket can be
> connected. Here should go something like "if (is_bound(&ii->ie))" where
> is_bound() checks for the name being non empty or smth like this.

Yeah, missed UDP case. Thanks, will fix.

	Cyrill


More information about the CRIU mailing list