[CRIU] Re: [PATCH 4/8] files: Print error if fcntl failed

Cyrill Gorcunov gorcunov at openvz.org
Thu May 10 06:46:45 EDT 2012


On Thu, May 10, 2012 at 02:13:29PM +0400, Pavel Emelyanov wrote:
> On 05/05/2012 07:20 PM, Cyrill Gorcunov wrote:
> > 
> > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> > ---
> >  files.c |   19 +++++++++++++------
> >  1 files changed, 13 insertions(+), 6 deletions(-)
> > 
> 
> Applied, but I yet again remind you not to put two things in
> one patch. Changing old to ret just while you were at it wasn't
> very helpful :\

The patch changed the semantics of 'old' and leaving it named 'old'
not longer reflect what is used for, thus the change should be
done in one patch.

	Cyrill


More information about the CRIU mailing list