[CRIU] Re: [PATCH 00/14] Add checkpoint/restore for eventfd/eventpoll/inotify

[Pavel Emelyanov]

On 04/29/2012 05:14 PM, Cyrill Gorcunov wrote:
> Hi this series introduces checkpoint/restore for eventfd/eventpoll/inotify.
> Please don't forget to pull latest changes from our kernel repo, which
> has needed functionality.
> 
> The summary changes are
> 
>  25 files changed, 1386 insertions(+), 22 deletions(-)
> 
> which is a bit bigger than I expected, but they could be
> fixed/cleaned on top I think.
> 
> Comments are welcome.

Comment on the overall inotify/eventfd/eventpoll:

Great, but this:

> p->id = MAKE_FD_GENID(p->stat.st_dev, p->stat.st_ino, p->pos);

isn't nice. Need more thinking on this place in the future (put in your TODO list).

Thanks,
Pavel