[CRIU] Re: [PATCH 06/14] eventpoll: Add checkpoint/restore

[Pavel Emelyanov]

On 04/29/2012 05:14 PM, Cyrill Gorcunov wrote:
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> ---
>  cr-dump.c         |   12 +++
>  cr-restore.c      |    3 +
>  cr-show.c         |   43 +++++++++++
>  crtools.c         |   14 ++++
>  eventfs.c         |  206 ++++++++++++++++++++++++++++++++++++++++++++++++++++-

Plz, put eventpoll to eventpoll.c file.

>  include/crtools.h |    6 ++
>  include/eventfs.h |    5 ++
>  include/image.h   |   16 ++++
>  8 files changed, 304 insertions(+), 1 deletions(-)

> +	if (fcntl(tmp, F_SETFD, info->efe.flags)) {
> +		pr_perror("Can't set flags on epoll %#08x",
> +			  info->efe.id);
> +		goto err_close;
> +	}
> +

This is wrong, see similar comment for eventfd.

> +		event.events	= td_info->tdefe.events;
> +		event.data.u64	= td_info->tdefe.data;
> +		ret = epoll_ctl(tmp, EPOLL_CTL_ADD, td_info->tdefe.tfd, &event);

What if the fd we're about to push there isn't yet opened?
I thought we've discussed it, but I don't see the respective hunk here.

Thanks,
Pavel