[CRIU] Re: [PATCH cr] proc: add a static buffer to prevent segv (v3)

Pavel Emelyanov xemul at parallels.com
Thu May 3 05:09:01 EDT 2012


On 05/02/2012 03:22 PM, Andrey Vagin wrote:
> A few of our functions use buffer and string functions.
> All these functions require that a string contains '\0' at the end.
> Before this patch we didn't guarantee that.
> 
> I've seen segmentation fault in parse_pid_stat_small.
> 
> v2: simplify code
> v3: remove assignment, because it's redundant and a size of object file
> become bigger.
> 
> Signed-off-by: Andrey Vagin <avagin at openvz.org>

I like this approach and take this patch, but we need (somtime in the future)
to generalize it.

Thanks,
Pavel



More information about the CRIU mailing list