[CRIU] Re: [PATCH 08/11] dump: Use parasite file descriptors draining

Pavel Emelyanov xemul at parallels.com
Wed Mar 28 14:52:00 EDT 2012


On 03/28/2012 05:36 PM, Cyrill Gorcunov wrote:
> 
> Since we're able to simply drain file descriptors
> we're interested in, just do that with parasite
> help.
> 
> This changes the calling sequence a bit
> 
>  1) Collect file descriptors before parasite
>     get intected the dumpee and remember them in
>     local copy.
> 
>  2) Ask parasite to drain collected descriptrs
>     into our space.
> 
>  3) Operate with file descriptors directly via fcntl
>     calls and such.
> 
> Overall idea is to prepare ground for fowners
> dumping which will be addressed in further patches.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> ---
>  cr-dump.c |  163 ++++++++++++++++++++++++++++++++++++-------------------------
>  1 files changed, 96 insertions(+), 67 deletions(-)
> 

OK, till this point patches look very good. Fix my comment in
patch #6 and I'll appli patches 1 through 8.

Thanks,
Pavel


More information about the CRIU mailing list