[CRIU] Re: [PATCH 1/6] make: Shrink amount of generated defines for parasite code

Pavel Emelyanov xemul at parallels.com
Wed Mar 28 06:00:20 EDT 2012


On 03/27/2012 11:34 PM, Cyrill Gorcunov wrote:
> On Tue, Mar 27, 2012 at 11:32:39PM +0400, Pavel Emelyanov wrote:
>> On 03/27/2012 06:45 PM, Cyrill Gorcunov wrote:
>>>
>>> No need to include every symbol found in generated object
>>> files, just define the minimum we need (after all we do not
>>> filter names by symbol types, so one day it might become
>>> a problem in names collision).
>>>
>>> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
>>> ---
>>>  gen-offsets.sh |    7 ++++++-
>>>  1 files changed, 6 insertions(+), 1 deletions(-)
>>>
>>
>> Put "needed" symbol names in a file and use grep -f
> 
> Yes, I thought about some gcc custom attribute here.
> Pavel, can we merge this series as is, I'll update
> on top then.

This is not about gcc flags! This is about writing it in one
line like this

nm $OBJNAME | grep -f "$FILE_WITH_REQUIRED_SYMBOLS" | tr . _ | awk "$AWK_CMD"

> 	Cyrill
> 



More information about the CRIU mailing list