[CRIU] Re: [PATCH 3/6] make: Redesign building of parasite and restorer blobs

[Pavel Emelyanov]

On 03/27/2012 06:45 PM, Cyrill Gorcunov wrote:
> 
> In order to make further modifications of parasite
> and restorer blobs easier the following is done
> 
>  1) Everything related to parasite/restorer is moved
>     into separate Makefile.pie because there are special
>     rules needed to build this files so escape messing with
>     general Makefile

What are the rules?

>  2) No need to host two lds files which do the same thing,
>     just merge them into one pie.lds.S.

What about symbol names? They are not the same for parasite
and restorer.

And this can be separate patch.

>  3) Tune up restorer-log.c functions declarations, they
>     are not always_inline but merged into built file with
>     ld help

This can be a separate patch as well.

>  4) Along with .bin files generate correspond .bin.o files
>     in debug purpose (one could disassemble them and check
>     the contents).

This can be separate patch as well.

> There is no easy way to split this patch because it touches
> all parts of building (compiling, linkind, generating deps
> and such).
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> ---
>  Makefile       |   76 ++++++-------------------------------------------------
>  Makefile.pie   |   63 ++++++++++++++++++++++++++++++++++++++++++++++
>  parasite.lds.S |   19 --------------
>  pie.lds.S      |   25 ++++++++++++++++++
>  restorer-log.c |   17 ++++--------
>  restorer.lds.S |   19 --------------
>  6 files changed, 103 insertions(+), 116 deletions(-)
>  create mode 100644 Makefile.pie
>  delete mode 100644 parasite.lds.S
>  create mode 100644 pie.lds.S
>  delete mode 100644 restorer.lds.S
>