[CRIU] Re: [PATCH 12/12] dump: files tree - few cleanups

[Pavel Emelyanov]

On 03/23/2012 08:24 PM, Kinsbursky Stanislav wrote:
> From: Stanislav Kinsbursky <skinsbursky at openvz.org>
> 
> 1) Use u8 instead of int for fd number.

This is risky. Tasks with more than 255 opened files is not a nonsense
these days...

> 2) Use genid from parent node while lookup subtree - one less parameter to
> pass.
> 3) Redundant NULL assigment for pointer removed.
> 4) Use parent instead on *new during tree walk.
> 
> Signed-off-by: Stanislav Kinsbursky <skinsbursky at openvz.org>
> ---
>  file-ids.c |   28 ++++++++++++----------------
>  1 files changed, 12 insertions(+), 16 deletions(-)