[CRIU] Re: [PATCH 1/2] make: Shrink amount of generated defines for parasite code

[Pavel Emelyanov]

On 03/23/2012 02:47 AM, Cyrill Gorcunov wrote:
> No need to include every symbol found in generated object
> files, just define the minimum we need (after all we do not
> filter names by symbol types, so one day it might become
> a problem in names collision).
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>

I don't want to keep in mind the fact that once a new symbol
is added I need to patch one more file. Why is "exporting"
everything is bad?

> ---
>  gen-offsets.sh |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/gen-offsets.sh b/gen-offsets.sh
> index 545b6d7..22252a6 100644
> --- a/gen-offsets.sh
> +++ b/gen-offsets.sh
> @@ -19,7 +19,12 @@ cat << EOF
>  
>  EOF
>  
> -nm $OBJNAME | tr . _ | awk "$AWK_CMD"
> +nm $OBJNAME | grep "restore_thread" | tr . _ | awk "$AWK_CMD"
> +nm $OBJNAME | grep "restore_task" | tr . _ | awk "$AWK_CMD"
> +nm $OBJNAME | grep "parasite_args" | tr . _ | awk "$AWK_CMD"
> +nm $OBJNAME | grep "parasite_cmd" | tr . _ | awk "$AWK_CMD"
> +nm $OBJNAME | grep "parasite_head_start" | tr . _ | awk "$AWK_CMD"
> +nm $OBJNAME | grep "parasite_service_complete" | tr . _ | awk "$AWK_CMD"
>  
>  cat << EOF
>