[CRIU] Re: [PATCH 07/28] dump: fd tree updated

[Pavel Emelyanov]

On 03/22/2012 09:58 PM, Kinsbursky Stanislav wrote:
> From: Stanislav Kinsbursky <skinsbursky at openvz.org>
> 
> 1) return id instead of structure instance
> 2) return new entry flag.
> 3) fd forest introduced.
> 4) enum for fd types introduced.

5) renames function names
6) changes typed #define-s into enum
7) removed fd_id_entry and adds some new think
8) did I miss something else?

How the hell can anyone review this patch?
Did you take a single attempt of thinking on this?

> 
> Signed-off-by: Stanislav Kinsbursky <skinsbursky at openvz.org>
> ---
>  cr-dump.c          |   15 ++----
>  file-ids.c         |  124 +++++++++++++++++++++++++++++++++++++---------------
>  include/file-ids.h |   27 +++--------
>  include/image.h    |   14 ++++--
>  4 files changed, 111 insertions(+), 69 deletions(-)