[CRIU] Re: [PATCH cr 2/7] mm: move shmid to vma_entry

Cyrill Gorcunov gorcunov at openvz.org
Mon Mar 19 12:32:52 EDT 2012


On Mon, Mar 19, 2012 at 06:49:58PM +0300, Andrey Vagin wrote:
...
> @@ -157,7 +157,7 @@ extern void pr_vma(unsigned int loglevel, const struct vma_area *vma_area);
>  	({							\
>  		struct vma_area *p__ = xzalloc(sizeof(*p__));	\
>  		if (p__) {					\
> -			p__->shmid	= -1;			\
> +			p__->vma.shmid	= 0;			\
>  			p__->vm_file_fd = -1;			\
>  			p__->vma.fd	= -1;			\
>  		}						\

Not a big deal, but assignment to 0 useless here, because we
use xzalloc anyway :)

	Cyrill


More information about the CRIU mailing list