[CRIU] Re: [PATCH] parasite: Refactor code to follow calling
convention
Pavel Emelyanov
xemul at parallels.com
Mon Mar 19 05:53:28 EDT 2012
On 03/19/2012 12:02 PM, Cyrill Gorcunov wrote:
> Hi Pavel,
>
> this patch should simplify parasite code error handling. There is
> only one helper for setting error code SET_PARASITE_RET. Also it's
> possible to call parasite_execute without arguments at all (in
> case if we have kind of function which never fails inside parasite).
> For example
>
> parasite_dump_pages_seized
> ...
> parasite_execute(PARASITE_CMD_DUMPPAGES_FINI, ctl, NULL, 0);
>
> the parasite_execute in turn has own BUG_ON just to check noone is breaking
> this convention.
>
> Overall I think this should simplify the code. Please review when you get
> opportunity.
>
> Cyrill
>
Applied
More information about the CRIU
mailing list