[CRIU] Re: [PATCH 1/4] dump: add pid number to image name only if it's not equal to zero

Pavel Emelyanov xemul at parallels.com
Fri Mar 16 09:47:51 EDT 2012


>>>> The fact that you check pid != 0 in get_image_path implies that you
>>>> might have some given CR_FD_-type global or local depending on the
>>>> conditions, but this is not so.
>>>>
>>>> Some types are per-task _always_, some are global _always_. That said
>>>> more logical patch is -- trim %d-s from global ones only and insert
>>>> a debugging check that when pid != 0 the fmt should contain %-s and
>>>> when pid == 0 -- should not.
>>> This will require more code, which will duplicates the existent.
>>> Why do we need separated open function for global image files?
>> I didn't say we do.
> 
> Then clarify your idea, please.
> Or you want me to guess?
> 

I want you to think. Take 10 minutes break for this. If fail -- come to
me to discuss.

Yet again -- some images are per-task and the others are global _always_.


More information about the CRIU mailing list