[CRIU] Re: [PATCH 2/3] restore: Don't close LAST_PID_PATH descriptor if it was not opened

Cyrill Gorcunov gorcunov at openvz.org
Mon Mar 12 06:36:18 EDT 2012


On Mon, Mar 12, 2012 at 02:18:26PM +0400, Stanislav Kinsbursky wrote:
> >
> >Oh, common Stas, do you really think I sit day/night just to
> >clean code up? And yes, I believe having some clean code is
> >a way more important than "lets finish all the todo things,
> >we will clean it later". No, we don't. There always be tasks
> >to implement, there always be bugs to fix. But the shite which
> >comes into the code almost for sure will live there only because
> >"we have tasks in todo". Hell no I buy it. Sorry if it was offensive ;)
> >
> 
> No, it was not. :)

I knew ;)

> And it's not my project. ;)
> 

Neither it mine, it's *our*! Still as I said in the very first message --
if there strong opinion against style I use, no problem I'll force myself
to change approach.

As for cleaning up and efforts spent -- well, at moment to implement file
owners dumping I _have_ to clean parasite service code, it's plainly
unreadable, and the problem is that adding a new code there (I have
to add new commands there) became more problematic than it should be.

	Cyrill


More information about the CRIU mailing list