[CRIU] Re: [PATCH 2/2] sckets: reorganize queues restore

Kinsbursky Stanislav skinsbursky at openvz.org
Tue Mar 6 09:51:14 EST 2012


05.03.2012 20:02, Pavel Emelyanov пишет:
> On 03/02/2012 06:36 PM, Kinsbursky Stanislav wrote:
>> First move peer packets to another list, then go over it without checks.
>> This allow to add some more usefull debug prints (nr of packets, for example).
>> It also allows to restore sockets queues in parallel (which cound be usefull
>> later).
> How? This list is local.

Yep, this string is just rubbish.

> And it allows to properly compare the queue lenght with socket buf, which is
> a) not mentioned in comment

Ok, I'll add something...

> b) done in a wrong manner in the patch -- you should instead raise one to
>     bigger value and then decrease it back to initial value (to a value from
>     socket image in the future)
>

Sound reasonable.

-- 
Best regards,
Stanislav Kinsbursky




More information about the CRIU mailing list