[CRIU] Re: [PATCH v3 3/8] dump: stat fd by fstatat()

Kinsbursky Stanislav skinsbursky at openvz.org
Tue Mar 6 05:37:05 EST 2012


06.03.2012 14:33, Cyrill Gorcunov пишет:
> On Tue, Mar 06, 2012 at 02:31:00PM +0400, Kinsbursky Stanislav wrote:
> ...
>>>>> In patch #1 you moved this read_fd_parms lower. Now you move it back.
>>>>> I like to move it, move it, I like to move it move it?
>>>> It's not me - it's diff.
>>>> IOW, in first patch I've moved read_fd_params() below fstat().
>>>> In this one I moved openat() below read_fd_params().
>>> Isn't it easier to move fstat above the read_fd_parms and relax?
>> Maybe. Need to check.
>> BTW, I don't think, that we need to concentrate on this minor issues.
>>
> Guys, please, can we stop overquoting messages? ;)
>
> 	Cyrill

I'm not really sure about it... :)


-- 
Best regards,
Stanislav Kinsbursky




More information about the CRIU mailing list