[CRIU] Re: [PATCH v3 5/8] dump: hide local opened fd into fd params

[Pavel Emelyanov]

> @@ -362,17 +373,17 @@ static int dump_one_fd(pid_t pid, int pid_fd_dir, char *d_name, struct cr_fdset
>  		 */
>  	case S_IFREG:
>  	case S_IFDIR:
> -		err = dump_one_reg_file(&p, lfd, cr_fdset, 0);
> +		err = dump_one_reg_file(&p, cr_fdset, 1);
>  		break;
>  	case S_IFIFO:
> -		err = dump_one_pipe(&p, lfd, cr_fdset);
> +		err = dump_one_pipe(&p, cr_fdset);
>  		break;
>  	case S_IFSOCK:
>  		err = try_dump_socket(pid, p.fd_name, cr_fdset, sk_queue);
>  		if (err != 1)
>  			return err;
>  
> -		pr_perror("Failed to open %d/%s", pid_fd_dir, d_name);
> +		pr_perror("Failed to open %d/%ld", pid_fd_dir, p.fd_name);

Huh? We don't do open now for sockets.

>  		return -1;
>  	case S_IFLNK:
>  	case S_IFBLK: