[CRIU] Re: [PATCH v2 06/11] dump: add pid_fd_dir for fd params

[Kinsbursky Stanislav]

05.03.2012 20:15, Pavel Emelyanov пишет:
> On 03/05/2012 08:05 PM, Kinsbursky Stanislav wrote:
>> 05.03.2012 19:41, Pavel Emelyanov пишет:
>>> On 03/05/2012 04:38 PM, Kinsbursky Stanislav wrote:
>>>> Will be usefull later when fd reopen will be perfermed only where required.
>>>>
>>>> Signed-off-by: Stanislav Kinsbursky<skinsbursky at openvz.org>
>>>>
>>>> ---
>>>>    cr-dump.c |   13 ++++++++-----
>>>>    1 files changed, 8 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/cr-dump.c b/cr-dump.c
>>>> index 39590b7..b880f8e 100644
>>>> --- a/cr-dump.c
>>>> +++ b/cr-dump.c
>>>> @@ -93,6 +93,7 @@ struct fd_parms {
>>>>    	unsigned int	flags;
>>>>    	unsigned int	type;
>>>>    	ino_t		ino;
>>>> +	int		pid_fd_dir;
>>>>
>>>>    	u64		id;
>>>>    	pid_t		pid;
>>> fd_parms is not a way to reduce the amount of arguments walking up and down
>>> the stack, but a structure which represents a file descriptor parameters. The
>>> pid_fd_dir has nothing to do with it.
>> I'm trying to unify dump_one*() functions prototypes.
>> Someday they could be even derefenced by pointers. If not - then anyway -
>> unified code look better.
>> This pid_fd_nr is not used for sockets. So, I decided to remove it from general
>> code.
>> You don't like the idea itself or implementation only?
> Hm... I guess implementation only.

Ok, I'll try to wrap it somehow else...

-- 
Best regards,
Stanislav Kinsbursky