[CRIU] Re: [PATCH v2 02/11] dump: hide pararms id set into read_fd_params()

[Kinsbursky Stanislav]

05.03.2012 19:36, Pavel Emelyanov пишет:
>> @@ -322,12 +326,9 @@ static int dump_one_fd(pid_t pid, int pid_fd_dir, char *d_name, struct cr_fdset
>>   	struct fd_parms p;
>>   	int lfd;
>>
>> -	if (read_fd_params(pid, d_name,&p))
>> -		return -1;
>> -
>>   	lfd = openat(pid_fd_dir, d_name, O_RDONLY);
>>   	if (lfd<  0) {
>> -		err = try_dump_socket(pid, p.fd_name, cr_fdset, sk_queue);
>> +		err = try_dump_socket(pid, atoi(d_name), cr_fdset, sk_queue);
>>   		if (err != 1)
>>   			return err;
>>
> Here below there's a reference to p.fd_name which is left uninitialized by your patch.

Yep, but this reference will be removed later in the series.

-- 
Best regards,
Stanislav Kinsbursky