[CRIU] Re: [PATCH 3/3] restore: Don't close pstree_fd several times

Cyrill Gorcunov gorcunov at openvz.org
Mon Mar 5 10:35:15 EST 2012


On Mon, Mar 05, 2012 at 07:31:58PM +0400, Pavel Emelyanov wrote:
> On 03/04/2012 01:39 AM, Cyrill Gorcunov wrote:
> > There is a scenario when pstree_fd may be tried
> > to close several times -- if we start crtools
> > with "detach" option. So instead of adding various
> > if () constructions -- simply pass a pointer to
> > file descriptor and use close_safe which is immune
> > against closed file.
> 
> I'd better make restore_root_task close it always and patched the
> caller to simply do return restore_root_task().
> 

Sure. I'll update.

	Cyrill


More information about the CRIU mailing list