[CRIU] Re: [PATCH 1/10] parasite: Check for unexpected signals delivery

[Pavel Emelyanov]

On 03/01/2012 07:25 PM, Cyrill Gorcunov wrote:
> On Thu, Mar 01, 2012 at 07:01:05PM +0400, Pavel Emelyanov wrote:
>>  
>> +	ctl->signals_blocked = 1;
>> +
>>  	ret = parasite_set_logfd(ctl, pid);
>>  	if (ret) {
>>  		pr_err("%d: Can't set a logging descriptor\n", pid);
> 
> Pavel, I don't like this. The signal blocking is done iside parasite
> itself so this is a _parasite_ code who should set this bit. Which
> means I think we should tune it up on top and pass signals_blocked
> as a part of parasite arguments, then simply copy it to control
> block.
> 
> And I think we can do this on top of this series of course. Sounds
> reasonable?

I don't see how parasite can set up this bit on a crtools-side structure,
but if you find some elegant way of doing this -- please do.

> 	Cyrill
>