[CRIU] Re: [PATCH 3/7] fifo: Add checkpoint restore for fifos v2

[Cyrill Gorcunov]

On Thu, Jun 28, 2012 at 09:42:46PM +0400, Pavel Emelyanov wrote:

after thinking some more

> 
> 1. Put the comment about this

ok

> 2. Use the open_reg_by_id -- it does exactly what you need
> 3. Pass the real_open callback explicitly as functions argument instead
>    of hiding one on file_desc structure
> 

I find it inconvenient, open_reg_by_id is already used

[cyrill at moon crtools]$ git grep open_reg_by_id
cr-restore.c:   exe_fd = open_reg_by_id(args->mm.exe_file_id);
fifo.c: open_reg_by_id
files-reg.c:int open_reg_by_id(u32 id)
files.c:        cwd = open_reg_by_id(fe.cwd_id);
files.c:        return open_reg_by_id(vma_entry->shmid);
include/files-reg.h:extern int open_reg_by_id(u32 id);

should I pass real_open for all callers? Actually I've had idea
of reworking this all completely to make more flexible design
on path remapping, so Pavel will you be fine if I

 - add explicit comment on 1)
 - add fixme for reg-files engine and will redesign this on
   weekend (i'm about to switch to tty task at moment)

Hm?

	Cyrill