[CRIU] Re: [PATCH 1/2] sockets: Restore unbound inet sockets v3

[Cyrill Gorcunov]

On Thu, Jun 28, 2012 at 09:12:36PM +0400, Pavel Emelyanov wrote:
> > +
> > +		if (info.tcpi_state != TCP_CLOSE) {
> > +			pr_err("Socket state %d obtained but expected %d\n",
> > +			       info.tcpi_state, TCP_CLOSE);
> > +			goto err;
> > +		}
> > +
> > +		sk->wqlen = info.tcpi_backoff;
> > +	} else
> > +		sk->wqlen = 16; /* default value */
> 
> This is bad default value.

Hmm, why? Which value would be appropriate here?
Or simply leave it zeroed?

> 
> > +	if (should_free_sk)
> > +		xfree(sk);
> 
> I'd push this socket into hash thus making the BUG_ON(sk->already_dumped) debug ON for them.

Ah, will update, thanks!

	Cyrill