On Thu, Jun 28, 2012 at 03:03:50PM +0400, Pavel Emelyanov wrote: > > > > + return -1; > > + > > if (parse_sb_opt(opt, &new->flags, new->options)) > > return -1; > > And free new->options here ;) I don't consider xfree miss on error path which leads > to ap termination as critical. Sure it's not critical at all but a bit unpleasant ;) Cyrill