[CRIU] Re: [PATCH 2/5] fifo: Add checkpoint restore for fifos

[Cyrill Gorcunov]

On Tue, Jun 26, 2012 at 01:54:15PM +0400, Pavel Emelyanov wrote:
> On 06/26/2012 01:51 PM, Cyrill Gorcunov wrote:
> > On Tue, Jun 26, 2012 at 01:37:36PM +0400, Pavel Emelyanov wrote:
> >>
> >> The patch got corrupted. Use attach.
> > 
> > yeah, sorry
> > 
> >>> +       if (dump_one_reg_file(lfd, id, p))
> >>> +               return -1;
> >>
> >> Good. But the dump_ghost_file on unlinked fifo will try to copy out
> >> its contents. Not good.
> > 
> > ok, will update (nothing critical though since the file is empty
> 
> Empty?! Don't we support fifo-s with data?

You miss the point, we use copy_file to copy contents of the file
and fifo file itself is empty, the data associated with fifo is
holding inside kernel buffers and we dump/restore contents of such
buffers via tee/splice to fifo-data.img, but this data has nothing
to do with fifo file itself :)

	Cyrill