[CRIU] Re: [PATCH 2/2] tty: Add checkpoint/restore for ttys

[Cyrill Gorcunov]

On Thu, Jun 21, 2012 at 04:29:05PM +0400, Cyrill Gorcunov wrote:
> > I said nothing about another processes. Let's imagine, that we have one
> > process.
> > slave_fd = 1
> > master_fd = 2
> 
> Thus you mean the case where slave-fd get the number less than master_fd
> and get tried to receive fd via scm while mister fd is not yet even created.
> 
> This is resolved via partial ordering in
> 
> +		switch (info->major) {
> +		case TTYAUX_MAJOR:
> +			list_add(&info->list, &all_ttys);
> +			break;
> +		case UNIX98_PTY_SLAVE_MAJOR:
> +			list_add_tail(&info->list, &all_ttys);
> +			break;
> 
> if only I've not missed something obvious.

Hmm, it seems indeed the scenario you've pointed at might lock up the
restore, thanks, will think about it!

	Cyrill