[CRIU] Re: [PATCH 2/3] zdtm: Don't wait for dump forever

[Andrew Vagin]

On Fri, Jun 01, 2012 at 08:38:12PM +0400, Cyrill Gorcunov wrote:
> In case if something goes wrong with
> dumping better to exit rather than
> stuck forever.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> ---
>  test/zdtm.sh |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/test/zdtm.sh b/test/zdtm.sh
> index b2da0ab..230292c 100644
> --- a/test/zdtm.sh
> +++ b/test/zdtm.sh
> @@ -116,7 +116,7 @@ run_test()
>  		diff_fds $ddump/dump.fd $ddump/dump.fd.after || return 1
>  		killall -CONT $tname
>  	else
> -		while :; do
> +		for i in `seq 50`; do
Actually this loop is redundant. crtools should kill all processes if
crtools dump completed successfully.
I would like to add a check, that all test processes are killed.
>  			killall -9 $tname &> /dev/null || break
>  			echo Waiting for $tname complete dumping...
>  			sleep 1

> -- 
> 1.7.7.6
>