[CRIU] Re: Before we do the CRIU v0.1 release

[Pavel Emelyanov]

On 07/20/2012 01:14 PM, Cyrill Gorcunov wrote:
> Please check updated variant.
> 
> 	Cyrill

This is close to be perfect :) One last comment from me:

>  +static CoreEntry *core_entry_alloc(int alloc_optionals)
>  ...
>  static int dump_task_core_all(pid_t pid, const struct proc_pid_stat *stat,
> +       core = core_entry_alloc(1);
>  ...
> @@ -1130,7 +1215,7 @@ static int dump_task_thread(struct parasite_ctl *parasite_ctl, struct pid *tid)
> +       core = core_entry_alloc(0);
>  ...
>  static int dump_one_zombie(const struct pstree_item *item,
> +       core = core_entry_alloc(1);

In core we have 3 sub-messages: tc, thread_info and ids.
For alive main thread we allocate all, for sub-thread -- only thread_info, this is correct.
But for zombie we should allocate only tc. The thread_info and ids are useless for it.

Please fix and I apply the patch.

Thanks,
Pavel