[CRIU] Re: Before we do the CRIU v0.1 release

[Pavel Emelyanov]

On 07/20/2012 12:53 PM, Cyrill Gorcunov wrote:
> On Fri, Jul 20, 2012 at 12:14:02PM +0400, Pavel Emelyanov wrote:
>>
>>> +message core_entry {
>>> +       enum march {
>>> +               UNKNOWN         = 0;
>>> +               X86_64          = 1;
>>> +       }
>>> +
>>> +       required march                  mtype           = 1;
>>> +       optional thread_info_x86        thread_info     = 2;
>>> +
>>> +       required task_core_entry        tc              = 3;
>>> +       required core_ids_entry         ids             = 4;
>>> +}
>>
>> Both tc and ids MUST be optional and SHOULD NOT be dumped for threads.
>> Main thread MUST fail restore if these fields are missing.
>> (The thread_info MUST be present on restore, but MUST remain optional.)
> 
> Btw, task_core_entry is NOT optional for threads
> 
> dump_task_thread
> 	...
> 	core->tc->task_state = TASK_ALIVE;
> 	core->tc->exit_code = 0;
> 
> restore_one_task
> 	...
> 	switch ((int)core->tc->task_state) {
> 	...

This is main thread restore path. How about the sub-threads?

> 	Cyrill
> .
>