[CRIU] Re: [PATCH 7/9] protobuf: Convert IPC entries to PB format

[Pavel Emelyanov]

On 07/19/2012 10:53 AM, Cyrill Gorcunov wrote:
> On Thu, Jul 19, 2012 at 10:51:32AM +0400, Pavel Emelyanov wrote:
>> On 07/19/2012 10:46 AM, Cyrill Gorcunov wrote:
>>> On Thu, Jul 19, 2012 at 07:26:02AM +0400, Pavel Emelyanov wrote:
>>>>>
>>>>> I've just sent out an update to this patch in another thread,
>>>>> should I put it here as well?
>>>>>
>>>> Yes, please.
>>>
>>> Here we go.
>>>
>>> 	Cyrill
>>
>>> @@ -0,0 +1,6 @@
>>> +import "ipc-desc.proto";
>>> +
>>> +message ipc_sem_entry {
>>> +	required ipc_desc_entry	desc	= 1;
>>> +	required uint32		nsems	= 2;
>>> +}
>>
>> I must have missed this, but still.
>> Why don't we put here the repeated bytes values?
> 
> Pavel, I could try make it so, but I would prefer
> this version get merged first (since it works
> and rather does 1:1 mapping between old code
> and new code). And then we could optimize and
> enhance it, agreed?

:\ If "then" means "this evening or tomorrow morning" then OK.

Stas, need your Acked-By or at least Reviewd-By:

> 	Cyrill
> .
>