[CRIU] Re: [PATCH 8/8] protobuf: Convert IPC entries to PB format

Stanislav Kinsbursky skinsbursky at parallels.com
Wed Jul 18 06:58:19 EDT 2012


18.07.2012 14:48, Cyrill Gorcunov пишет:
> On Wed, Jul 18, 2012 at 02:36:46PM +0400, Stanislav Kinsbursky wrote:
>> 18.07.2012 14:30, Cyrill Gorcunov пишет:
>>> On Wed, Jul 18, 2012 at 02:16:55PM +0400, Stanislav Kinsbursky wrote:
>>>>>
>>>>> +#include "protobuf.h"
>>>>> +#include "protobuf/ipc-var.pb-c.h"
>>>>> +#include "protobuf/ipc-desc.pb-c.h"
>>>>
>>>> Does this include really required?IpcMsg msg = IPC_MSG__IN
>>>
>>> Yeah, the ipc-desc.pb-c.h is included implicilty in other headers,
>>> we can drop it.
>>>
>>
>> So, please do. Excessive usage of headers make me scary and crying...
>
> Update enveloped
>

I'd optimise this code a bit, but it'd be just "bells and whistles".
So ack.


-- 
Best regards,
Stanislav Kinsbursky





More information about the CRIU mailing list