[CRIU] Re: [PATCH 6/6] protobuf: Convert sk_packet_entry to PB engine

[Cyrill Gorcunov]

On Tue, Jul 17, 2012 at 04:10:04PM +0400, Cyrill Gorcunov wrote:
> On Tue, Jul 17, 2012 at 02:21:27PM +0400, Cyrill Gorcunov wrote:
> > On Tue, Jul 17, 2012 at 02:18:26PM +0400, Pavel Emelyanov wrote:
> > > >>
> > > >> options dump/restore -- should be separate patch
> > > > 
> > > > How? They are part of sk-unix.proto.
> > > 
> > > Helpers and .proto file in one patch users in 2 others.
> > 
> > Unused functions lead us to the state where gcc complains on them.
> > Anyway, thanks for comments, Pavel, i'll try to address all complains.
> 
> Pavel, could you please check if these two patches looks good for you?
> 
> 	Cyrill
...
> From: Cyrill Gorcunov <gorcunov at openvz.org>
> Date: Tue, 17 Jul 2012 15:52:53 +0400
> Subject: [PATCH 2/2] protobuf: Convert unix_sk_entry to PB engine v2
>
... 
> +		ret = pb_read_eof(fd, &ui->ue, unix_sk_entry);
> +		if (ret <= 0)
>  			break;
>  
> -		if (ui->ue->namelen) {
> +		if (ui->ue->name.len) {
			...
> -		} else
> -			ui->name = NULL;
> +		}

Note, if ui->ue->name.len then ui->name = NULL will be set this
way by PB library upon reading.

	Cyrill