[CRIU] Re: [PATCH 1/8] protobuf: Convert struct pipe_data_entry to PB engine

Pavel Emelyanov xemul at parallels.com
Tue Jul 17 06:50:44 EDT 2012


On 07/17/2012 02:43 PM, Cyrill Gorcunov wrote:
> On Tue, Jul 17, 2012 at 02:28:56PM +0400, Cyrill Gorcunov wrote:
>> On Tue, Jul 17, 2012 at 02:23:01PM +0400, Pavel Emelyanov wrote:
>>>>> There will be a xfree(r->pde) on EOF. Why doesn't it crash?
>>>>
>>>> it'll be xfree(NULL) then (since pb_read sets r->pde = NULL).
>>>
>>> If pipe_data_read fails this will be non NULL :\
>>
>> crap, indeed, will fix, thanks!
> 
> Fix enveloped.
> 
> 	Cyrill

Applied


More information about the CRIU mailing list