[CRIU] Re: [PATCH 1/8] protobuf: Convert struct pipe_data_entry to PB engine

Cyrill Gorcunov gorcunov at openvz.org
Tue Jul 17 06:28:56 EDT 2012


On Tue, Jul 17, 2012 at 02:23:01PM +0400, Pavel Emelyanov wrote:
> >> There will be a xfree(r->pde) on EOF. Why doesn't it crash?
> > 
> > it'll be xfree(NULL) then (since pb_read sets r->pde = NULL).
> 
> If pipe_data_read fails this will be non NULL :\

crap, indeed, will fix, thanks!

	Cyrill


More information about the CRIU mailing list