[CRIU] Re: [PATCH 6/8] protobuf: Convert struct pipe_data_entry to PB engine

[Cyrill Gorcunov]

On Fri, Jul 13, 2012 at 07:53:58AM +0400, Pavel Emelyanov wrote:
> On 07/12/2012 05:56 PM, Cyrill Gorcunov wrote:
> > 
> > Note, at moment we don't use "data" from proto declaration,
> > it's reserved to implement later (simply because it's easier
> > to use current code for a while).
> > 
> > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> > ---
> >  cr-show.c                |   10 ++++++----
> >  include/image.h          |    7 -------
> >  include/pipes.h          |    5 ++++-
> >  pipes.c                  |   12 +++++-------
> >  protobuf/Makefile        |    1 +
> >  protobuf/pipe-data.proto |   17 +++++++++++++++++
> >  6 files changed, 33 insertions(+), 19 deletions(-)
> >  create mode 100644 protobuf/pipe-data.proto
> > 
> 
> > @@ -0,0 +1,17 @@
> > +/*
> > + * We use fixed32 type here to be able to calculate
> > + * message size and update its fields later without
> > + * recalculation.
> > + */
> 
> Where is it strictly written in docs that fixed fields result
> in constant packed size?

I got it from PB source code, and btw here is as well
https://developers.google.com/protocol-buffers/docs/proto
see fixedX types description.

> 
> Then remove it.
> 

ok

	Cyrill