[CRIU] Re: [PATCH 6/8] protobuf: Convert struct pipe_data_entry to PB engine

[Pavel Emelyanov]

On 07/13/2012 10:12 AM, Pavel Emelyanov wrote:
> On 07/13/2012 07:53 AM, Pavel Emelyanov wrote:
>> On 07/12/2012 05:56 PM, Cyrill Gorcunov wrote:
>>>
>>> Note, at moment we don't use "data" from proto declaration,
>>> it's reserved to implement later (simply because it's easier
>>> to use current code for a while).
> 
> No, even not this way. I will get rid of the pipe_data_entry offset soon.

Done. Please pull the repo's master branch.

>>> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
>>> ---
>>>  cr-show.c                |   10 ++++++----
>>>  include/image.h          |    7 -------
>>>  include/pipes.h          |    5 ++++-
>>>  pipes.c                  |   12 +++++-------
>>>  protobuf/Makefile        |    1 +
>>>  protobuf/pipe-data.proto |   17 +++++++++++++++++
>>>  6 files changed, 33 insertions(+), 19 deletions(-)
>>>  create mode 100644 protobuf/pipe-data.proto
>>>
>>
>>> @@ -0,0 +1,17 @@
>>> +/*
>>> + * We use fixed32 type here to be able to calculate
>>> + * message size and update its fields later without
>>> + * recalculation.
>>> + */
>>
>> Where is it strictly written in docs that fixed fields result
>> in constant packed size?
>>
>>> +message pipe_data_entry {
>>> +	required fixed32	pipe_id		= 1;
>>> +	required fixed32	bytes		= 2;
>>> +	required fixed32	off		= 3;
>>> +
>>> +	/*
>>> +	 * At moment we dont use this field but write
>>> +	 * data directly after this member into the
>>> +	 * image file.
>>> +	 */
>>> +	optional bytes		data		= 4;
>>> +}
>>
>> Then remove it.
>>
>