[CRIU] Re: [PATCH 0/4] protobuf series updated

Stanislav Kinsbursky skinsbursky at parallels.com
Mon Jul 9 04:29:05 EDT 2012


07.07.2012 01:03, Cyrill Gorcunov пишет:
> Please take a look, thanks.
>

I like the patch set. So ack.
But I don't see descriptive comment for this hack with void pointers for 
protobuf helper functions.

I believe, that just above the declaration of the helpers something like this 
should present:
"
NOTE: Passing of void pointer to protobuf helpers is a dirty ugly hack.
But this is the best solution, because otherwise ... < proper descriptive 
explanation, why >
"


-- 
Best regards,
Stanislav Kinsbursky





More information about the CRIU mailing list