[CRIU] Re: [PATCH 4/4] protobuf: Use FdinfoEntry instead of struct fdinfo_entry

[Pavel Emelyanov]

On 07/06/2012 07:32 PM, Cyrill Gorcunov wrote:
> 
> This patch get rid of fdinfo_entry and start using protobuf
> facility for real.
> 
> Note that PB entries once unpacked should be referred via
> pointers, not by values, because one day .proto file might
> be changed leading to unpredicted results.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> ---
>  cr-dump.c          |   18 ++++++--------
>  cr-show.c          |   17 ++++++-------
>  file-ids.c         |    2 +-
>  files.c            |   62 +++++++++++++++++++++++++++------------------------
>  include/file-ids.h |    5 ++-
>  include/files.h    |    6 +++-
>  include/image.h    |    7 ------
>  include/sockets.h  |    1 -
>  pipes.c            |   12 +++++-----
>  sk-unix.c          |   20 ++++++++--------
>  10 files changed, 73 insertions(+), 77 deletions(-)
> 

> @@ -38,13 +40,13 @@ struct fdinfo_list_entry {
>  	struct list_head	ps_list;
>  	int			pid;
>  	futex_t			real_pid;
> -	struct fdinfo_entry	fe;
> +	FdinfoEntry		*fe;
>  };
>  

This deserves separate patch.

-	struct fdinfo_entry	fe;
+	struct fdinfo_entry	*fe;