[CRIU] Re: [PATCH 2/5] This patch introduces base message prototypes Google's protobuf facility.

[Pavel Emelyanov]

On 07/05/2012 12:01 PM, Cyrill Gorcunov wrote:
> On Thu, Jul 05, 2012 at 11:46:34AM +0400, Stanislav Kinsbursky wrote:
>> 05.07.2012 10:04, Cyrill Gorcunov пишет:
>>> On Thu, Jul 05, 2012 at 09:48:25AM +0400, Stanislav Kinsbursky wrote:
>>>>> +
>>>>> +message img_hdr {
>>>>> +	required fixed64			magic		= 1;
>>>>> +	required fixed64			version		= 2;
>>>>> +	required fixed64			flags		= 3;
>>>>
>>>> What are these flags stands for?
>>>
>>> Consider it as reserved for now. We don't use it at moment but might
>>> need in future.
>>>
>>
>> Protobuf allows easy add of new fields.
>> Why do we need to reserve space?
> 
> This will require to change version and read/write procedure in sake of

No it will not. You can feed longer messages to apps get compiled with shorter ones.

> speed up, does it worth that?
> 
> If there is strong objection against reserving "flags" field -- I can
> drop it, it's not a problem. But when we need it back again we will
> have to rewrite image header read code because it's designed to be
> very fast (as well as object headers).
> 
> 	Cyrill