[CRIU] Re: [PATCH 2/3] protobuf: Introduce base message prototypes

[Pavel Emelyanov]

On 07/04/2012 12:41 PM, Cyrill Gorcunov wrote:
> On Wed, Jul 04, 2012 at 12:28:22PM +0400, Pavel Emelyanov wrote:
>>
>> First of all -- I do not like the idea of pulling event bits of the protobuffer engine
>> into the crtools. If there's no other way of dumping pages then let's just dump them in
>> a raw format.
> 
> Why? Pavel, it looks very strane when we dump some data in PB format and some
> data in some own format. Such incosistency in design makes me cry, really. We
> either should keep everything in PB, either should simply stick with our own
> format.

No, images with pages are special. If you want to keep vaddrs in protobuffer format,
then reorganize the image. E.g. pull them from the parasite, encode in the crtools
core and store them at the head.

> Look, the PB format in binary representation is ABI written in stone. So
> we _just_ need two very small helper functions to keep everything in PB.

No. IFF these helpers are in protobuffer lib header and we can include it in parasite.c,
then OK, but copying it from there is a bad idea.

> 	Cyrill
> .
>