[CRIU] Re: [PATCH cr 7/7] restore: annotate restore phases

[Pavel Emelyanov]

On 07/02/2012 03:25 PM, Andrey Vagin wrote:
> 
> Signed-off-by: Andrey Vagin <avagin at openvz.org>
> ---
>  include/restorer.h |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 

>  enum {
> -	CR_STATE_FORKING,
> -	CR_STATE_RESTORE_PGID,
> -	CR_STATE_RESTORE,
> -	CR_STATE_RESTORE_SIGCHLD,
> -	CR_STATE_COMPLETE
> +	CR_STATE_FORKING,		/* Create a process tree */
> +	CR_STATE_RESTORE_PGID,		/* Restore PGID */
> +	CR_STATE_RESTORE,		/* Restore other stuff like files, pipes, etc */
> +	CR_STATE_RESTORE_SIGCHLD,	/* Restore the origin SIGCHLD handler */
> +	CR_STATE_COMPLETE		/* Resume the origin tasks */
>  };

No, no, no. CR_STATE_RESTORE_PGID /* Restore PGID */ is no smth I asked for :)
I need comment describing _why_ every stage is required, not what it's doing.