[CRIU] Re: [PATCH 0/7] fifo c/r updated
Cyrill Gorcunov
gorcunov at openvz.org
Sun Jul 1 08:45:05 EDT 2012
On Sun, Jul 01, 2012 at 04:38:42PM +0400, Pavel Emelyanov wrote:
> > + if (!S_ISFIFO(gfe.mode)) {
>
> This should be S_ISREG
>
Done.
> > +
> > + if (info->restore_data) {
> > + if (restore_pipe_data(CR_FD_FIFO_DATA, fake_fifo, info->fe.id,
> > + info->bytes, info->off)) {
> > + close(new_fifo);
> > + new_fifo = -1;
> > + }
> > + }
>
> Fifo data restore is not a part of fifo virtual opening by open_fe_fd.
> This part should be in static int open_fifo_fd(struct file_desc *d).
Look, I can't write data to say ro fifo, thus I restore it on
fake fifo end which has rw mode.
Cyrill
More information about the CRIU
mailing list