[CRIU] Re: [PATCH v2] dump: wait task stopped for 1 sec

Kinsbursky Stanislav skinsbursky at openvz.org
Tue Jan 31 09:27:25 EST 2012


31.01.2012 17:54, Pavel Emelyanov пишет:
> On 01/31/2012 05:31 PM, Kinsbursky Stanislav wrote:
>> 31.01.2012 17:29, Pavel Emelyanov пишет:
>>> On 01/31/2012 04:43 PM, Kinsbursky Stanislav wrote:
>>>> From: Stanislav Kinsbursky<skinsbursky at parallels.com>
>>>>
>>>> Wait for 1 sec in case of task is not stopped to dump stage and check it's
>>>> state once more.
>>>> Should help against this error:
>>>>
>>>> Obtainting task stat ... Error (cr-dump.c:1213): Task in bad state: R
>>>>
>>>> Signed-off-by: Stanislav Kinsbursky<skinsbursky at parallels.com>
>>> Synchronizing with sleep()-s just sucks.
>> Waiting for better solutions from you, Pavel. :)
>>
> We should remove sending STOP to tasks and do ptrace's SEIZE + INTERRUPT right
> on the collecting pstree stage.

Are you going to implement in today? If yes - cool then.
Otherwise it's impossible to test local changes, if test subsystem is not working.
This patch is a temporary fix.
Anyway, I'll use it in my tree. It's up to you how to solve the problem.

-- 
Best regards,
Stanislav Kinsbursky




More information about the CRIU mailing list