[CRIU] Re: [PATCH] crtools: Fix partially opened file set in cr_fdset helpers (v2)

Cyrill Gorcunov gorcunov at openvz.org
Tue Jan 31 04:27:49 EST 2012


On Tue, Jan 31, 2012 at 01:23:51PM +0400, Cyrill Gorcunov wrote:
> The caller expects to obtain NULL in case of any
> errors happened but in turn we might return some
> garbage instead.
> 
> Moreover prep_cr_fdset_for_restore might treat magic
> number as file descriptor in case of magic number
> mismatch, which is bloody wrong.
> 

Heh, this is not really true, I simply misread 'ret' usage,
still the patch is needed.

	Cyrill


More information about the CRIU mailing list