[CRIU] Re: [PATCH 3/4] IPC: restore namespace itself

[Pavel Emelyanov]

On 01/31/2012 12:05 PM, Kinsbursky Stanislav wrote:
> 30.01.2012 22:04, Pavel Emelyanov пишет:
>>> +static int prepare_ipc_data(int fd)
>>> +{
>>> +	int ret;
>>> +	struct ipc_ns_data ipc;
>>> +
>>> +	ret = read_img(fd,&ipc);
>>> +	if (ret<= 0)
>>> +		return -EFAULT;
>>> +	ret = prepare_ipc_tun(&ipc.entry);
>>> +	if (ret<  0)
>>> +		return ret;
>>> +	return 0;
>> return prepare_ipc_tun(&ipc.entry);
> 
> Wanted to object here. But then realized, that that will be a waste of time.

Shame on you then.

> Will do as requested. But this place will be rewritten soon.

You mean that you'll add

ret = prepare_ipc_sems();
if (ret < 0)
	return ret;

ret = prepare_ipc_msgs();
if (ret < 0)
	return ret;

soon?

It's OK to keep this as is in that case.

Thanks,
Pavel