[CRIU] Re: [PATCH] parasite: remove unused headers

Cyrill Gorcunov gorcunov at openvz.org
Tue Feb 28 11:51:35 EST 2012


On Tue, Feb 28, 2012 at 08:46:55PM +0400, Stanislav Kinsbursky wrote:
> 28.02.2012 20:24, Cyrill Gorcunov пишет:
> >On Tue, Feb 28, 2012 at 08:17:38PM +0400, Stanislav Kinsbursky wrote:
> >>Ping
> >>
> >
> >Well, sorry for delay. The patch is wrong. You should not
> >drop compiler.h and probably type.h from there. Sure it'll
> >built even without it because of using other headers but
> >this is... wrong :)
> >
> >So if you don't mind I would tune it up a bit and commit.
> >Sounds good for you?
> >
> >	Cyrill
> 
> Sounds like there are some shit, not well hidden somewhere inside parasite.
> But I don't care - do whatever you think is right.
> 

OK. There is no shit, fundamental headers such as type.h and compiler.h
should be included explicitly, not because any other header might already
have them included.

	Cyrill


More information about the CRIU mailing list